SFTtech / openage

Free (as in freedom) open source clone of the Age of Empires II engine 🚀
http://openage.dev
Other
12.51k stars 1.11k forks source link

Coordinate types pretty print #1636

Closed heinezen closed 2 months ago

heinezen commented 2 months ago

Depends on https://github.com/SFTtech/openage/pull/1633

This just flattens the parent hierarchy to make the parent invisible and directly show the coordinate values.

heinezen commented 2 months ago

@TheJJ Wouldn't this require switching away from the decorator method? I would like to keep that for now, since it makes adding new printers pretty easy.

TheJJ commented 2 months ago

the decorator can be imported like any regular function, no?

heinezen commented 2 months ago

@TheJJ Yes, but to use the decorator, the module with the classes would have to be imported too. And somehow, gdb doesn't seem to like that. At least I get errors when I try that for the .gdbinit file but gdb doesn't print the exact issue. I'm not sure how to solve this yet, so having the printers all in one file is the best solution right now.

heinezen commented 2 months ago

@TheJJ Done :)

heinezen commented 2 months ago

Now it should be good to merge, finally