search

SFTtech / openage

Free (as in freedom) open source clone of the Age of Empires II engine 🚀
http://openage.dev
Other
12.65k stars 1.12k forks source link

Customizable key bindings #271

Closed TheJJ closed 8 years ago

TheJJ commented 9 years ago

Maybe store it as key-value pairs in ~/.openage/keybindings.

This file should have a config version on top once the format gets more sophisticated to perform/detect updates.

Ideally, the bindings are managed in it's own subsystem (libopenage/cvar?) to allow central storage and changes. The keys should probably point to functions that can be replaced at runtime. Avoid string lookups please.

depends on the cvar config subsystem from #486

detrumi commented 9 years ago

I'll start working on this.

mic-e commented 9 years ago

I guess after #284, only the "read-keybindings-from-file-or-whatever" part remains to be implemented.

connorjclark commented 8 years ago

I would like to begin contributing to this project, and I think this is a good way to start. I'll work on reading these key bindings from a configuration file.

StepS- commented 8 years ago

You might want to cooperate with @Elnabo then as I believe he already has started doing it in the meantime. (#526, #486)

elnabo commented 8 years ago

I didn't work on the reading part. But here is what I know about it, and what may be needed.

The keybinds are now part of the generic config file(s). The config file reading should be done in python to be easily integrated with the cvar system (#486).

So I think you should focus on extracting any kind of couple key/value and if possible have a possibility to save modification.

elnabo commented 8 years ago

I think that #537 has completed this issue, isn't it ?

TheJJ commented 8 years ago

YES! YES IT HAS!!!!

:beers: