Update build procedure - Githubissues

SFTtech / openage

Free (as in freedom) open source clone of the Age of Empires II engine 🚀

http://openage.dev

Other

12.73k stars 1.12k forks source link

Update build procedure #549

Closed TheJJ closed 7 years ago

TheJJ commented 8 years ago

https://github.com/SFTtech/openage/blob/master/doc/building.md#build-procedure

[ ] The ./configure script no longer accepts --cpp-compiler
[ ] The compiler versions should not be hardcoded, but it's probably difficult writing it in another way
[ ] Create subfiles for all the distros and operating systems, so the file is less clobbered

edgardmota commented 8 years ago

Hi... may I try to update this documentation? I'll probably need to discuss a little bit on how to perform some of the changes.

Thanks

TheJJ commented 8 years ago

Sure, go ahead!

edgardmota commented 8 years ago

As --cpp-compiler parameter no longer exists on ./configure, it seems that the hardcoded versions of compiler will not be an issue anymore: they only seem to be "wrongly" used altogether with --cpp-compiler, am I right?

Any prefered pattern to split specific os/distro build instructions on their own files? I was thinking of creating them this way on the same current path: building_<specific-distro-or-os-name>.md. The Idea is to provide links to them on building.md.

Any comment on such ideas would be nice!

Thanks,

TheJJ commented 8 years ago

The new --compiler flag is used to specify a custom compiler type/version easily. Namely, you can select clang instead of gcc that way. I think you can safely remove the hardcoded versions, yes.

If you wanna split it up, yes, great idea :) I'd create a new directory build_instructions/ or similar and then create files like ubuntu.md, gentoo.md and so on in there. The building.md can then link to them like you suggested.

edgardmota commented 8 years ago

Thanks for your comments, @TheJJ! I'll pick your suggestions.