search

SFTtech / openage

Free (as in freedom) open source clone of the Age of Empires II engine 🚀
http://openage.dev
Other
12.64k stars 1.11k forks source link

Unable to exit the prefix loop during detection of AoE2 installation #558

Closed elnabo closed 8 years ago

elnabo commented 8 years ago

When you use wine to detect the installation and are unable to enter a valid prefix you can't leave the loop. Or at least I didn't find how.

This does not appear to be a valid WINEPREFIX.
Enter a valid one, or leave it empty to skip.
WINEPREFIX=
This does not appear to be a valid WINEPREFIX.
Enter a valid one, or leave it empty to skip.

I was only able to leave this loop by sending a Ctrl + C

goto-bus-stop commented 8 years ago

https://github.com/SFTtech/openage/blob/master/openage/convert/main.py#L205

Given an empty string, expand_relative_path returns the current directory, so it doesn't break out of the loop.