search

SFTtech / openage

Free (as in freedom) open source clone of the Age of Empires II engine 🚀
http://openage.dev
Other
12.75k stars 1.13k forks source link

Flickering #581

Closed D8174 closed 8 years ago

D8174 commented 8 years ago

Video: https://www.youtube.com/watch?v=TZEiBMJ3IiY (warning: flickering) Running on Debian x86_64, compiled with g++ 6.1.

TheJJ commented 8 years ago

I can hardly explain where this comes from. We can only hope that #287 will fix it i guess.

D8174 commented 8 years ago

The last revision that didn't have flickering for me was 24fc81e, then the first one that did was 49fbd1a. I tried the revisions in-between but they gave me this: openage.cppinterface.exctranslate.CPPException: Failed to read CSV file /converted/string_resources.docx: Empty or missing. so unfortunately I can't be more specific.

VelorumS commented 8 years ago

Maybe because this line was added to libopenage/engine.cpp:

SDL_GL_SetAttribute(SDL_GL_STENCIL_SIZE, 8);

(and glClear(GL_COLOR_BUFFER_BIT | GL_STENCIL_BUFFER_BIT);)

'Failed to read' error for 5a776a6db20cb63fdf238227856bdd5a035fa67e is pretty impossible if it works for the previous one... There are just some functions and fields added that are not yet used.

D8174 commented 8 years ago

My mistake. I must have missed this, but the first revision that causes flickering is 3d0b0e8. The two revisions (5a776a6 and cb5e991) between just give a error: ‘gui_link’ does not name a type but I don't think that's important.

Edit: I'll try editing those lines you mentioned and report back.

D8174 commented 8 years ago

I commented SDL_GL_SetAttribute(SDL_GL_STENCIL_SIZE, 8); and removed GL_STENCIL_BUFFER_BIT but it still flickers.

VelorumS commented 8 years ago

Then maybe it's MakeCurrent() calls. The #595 has some magical effects on that if we're lucky.

VelorumS commented 8 years ago

And one other thing, pls: what is your 3d card and driver?

D8174 commented 8 years ago

Nvidia GTX 760 using proprietary driver version 352.79.

VelorumS commented 8 years ago

I've got the same card, 4GiB version. The difference is KDE/Unity.

D8174 commented 8 years ago

Well I found out what causes it... In my xorg.conf I have Option "TripleBuffer" "True" and disabling it fixes the flicker.

D8174 commented 8 years ago

So in my opinion this is pretty much a non-issue and can be closed.