search

SFTtech / openage

Free (as in freedom) open source clone of the Age of Empires II engine 🚀
http://openage.dev
Other
12.6k stars 1.11k forks source link

Can't stop the game while it is loading assets #608

Open jazzpi opened 7 years ago

jazzpi commented 7 years ago

On first launch, openage usually takes ~4-5 minutes to load all assets for me. During that time, pressing SHIFT-ESC in game or Ctrl-C in the console doesn't actually stop the game. It waits until all assets are loaded, then it immediately stops.

elnabo commented 7 years ago

I have this problem too. Nothing is displayed in the console, after the "wait for the assets to load" log message, for a few minutes.

coffenbacher commented 7 years ago

It seems like the ideal fix for this would just be to speed up the asset loading speed until this issue isn't noticeable. #327

Vanilla aoe2 boots for me in seconds, ~1.5-2 orders of magnitude faster than openage at the moment, so there's no reason we can't get there too

zuntrax commented 7 years ago

File loading speed in general will probably be fixed when nyan is in place. For now we should initialize the close keybind before trying to load assets.

jazzpi commented 7 years ago

I think the close keybinding is actually initialized since when you press it, the game window freezes up (noticeable in FPS counter and profiler), but the worker thread that reads the files just isn't stopped.

VelorumS commented 7 years ago

Terminating jobs in the middle isn't trivial. When I touched code around that case, I think I've noticed that there is no mechanism for that.

TheJJ commented 7 years ago

The loading time was reduced heavily by #685 so this should no longer be a "problem", but still the game can't be stopped while the loading is in progress.