search

SFTtech / openage

Free (as in freedom) open source clone of the Age of Empires II engine 🚀
http://openage.dev
Other
12.64k stars 1.11k forks source link

Flamegraph support #750

Open TheJJ opened 7 years ago

TheJJ commented 7 years ago

Our tests, demos and the game should have an easy way to generate flamegraphs.

Ideally, this would be integrated into the main python launcher, which is openage/__main__.py and the argparsing from there.

We should not add flamegraph as a dependency, but rather add a convenient (and documemented) way to run it.

Arkanosis commented 2 years ago

Hello,

Things have gotten a lot easier wrt to flamegraphs since 2017: wouldn't tools like KDAB/hotspot, KDE/heaptrack (and possibly KernelShark) be enough for what you had in mind?

The big pro is that they are easy to use and require no code instrumentation or project-specific documentation. The big con is that they are Linux-only.

Obviously, they also all target common metrics (CPU, RAM…), so that wouldn't help for niche metrics.

heinezen commented 2 years ago

@Arkanosis Thanks :) I think we can try and check them out. Since the flamegraphs should be an optional dependency anyway, it'd be okay that they have some constraints.