SFTtech / openage

Free (as in freedom) open source clone of the Age of Empires II engine 🚀
http://openage.dev
Other
12.63k stars 1.11k forks source link

Stuttering sound #96

Closed franciscod closed 9 years ago

franciscod commented 9 years ago

What I Do And What I Get:

I'd like to test the in_memory sound instead of the dynamic... but just changing this

                gamedata::audio_loader_policy_t::DYNAMIC

to this:

                gamedata::audio_loader_policy_t::IN_MEMORY

on game_main.cpp:205 doesn't work at all (no sound).

Can anyone reproduce? :sound: :loud_sound:

boombatower commented 9 years ago

I can reproduce the stutter. Again excellently illustrated description. :)

franciscod commented 9 years ago

Demo with the only two creation sounds that I can reproduce: http://fd1.com.ar/stutter.ogg

The "silence" blocks are clearly visible on both sounds and both "normal" and stuttering versions. Notice that the "normal" ones still have blank spaces but they are mostly unnoticeable by me

stutter

andrekupka commented 9 years ago

I can reproduce the stuttering sound, but I am wondering that the in-memory sound is not working at all. I try to fix it.

andrekupka commented 9 years ago

In-memory sounds should work again.

franciscod commented 9 years ago

yay! in memory working alright! thanks @fr3akout :smile:

andrekupka commented 9 years ago

Just a short addition: Dynamic audio loading is fixed by https://github.com/SFTtech/openage/commit/53f34f8248cb9d689de7d3f937a2eccec8566179

franciscod commented 9 years ago

nice! thanks! :D