SFTtech / sftmumblebot

Mumble/IRC text chat bridge :microphone: :love_letter:
GNU General Public License v3.0
49 stars 16 forks source link

SSL handshake error when connecting to Murmur 1.2.4 #1

Closed cydactyl closed 11 years ago

cydactyl commented 11 years ago

The bot throws http://pastebin.com/NX23ATff , while murmur throws 'Connection closed: Error during SSL handshake: error:1408F10B:SSL routines:SSL3_GET_RECORD:wrong version number [13]'

when attempting to connect.

I fixed the error and allowed the relay bot to connect by editing line 75 of MumbleConnection.py

I changed it from

        self._socket = ssl.wrap_socket(s)

to

        self._socket = ssl.wrap_socket(s, ssl_version = ssl.PROTOCOL_TLSv1)

I would be surprised if this was the correct fix, however it was the most simple hack I could do with absolutely no python knowledge.

TheJJ commented 11 years ago

we are looking into it, thx for report

waaaaargh commented 11 years ago

should be fixed as of commit 9c8a223.

waaaaargh commented 11 years ago

damn, we should definately test before committing :)

TheJJ commented 11 years ago

on our 1.2.4 test server the bot can join successfully. so probably the problem is caused by something else...

would you like to collaborate at irc.freenode.org #sftclan ?

TheJJ commented 11 years ago

we fixed it, right?