search

SFTtech / sftmumblebot

Mumble/IRC text chat bridge :microphone: :love_letter:
GNU General Public License v3.0
49 stars 16 forks source link

umurmur sends bot messages back leading to infinite bouces #13

Open m13253 opened 10 years ago

m13253 commented 10 years ago

My server is umurmur.

I type something in the IRC, the bot forwards to mumble, then forwards again back to IRC.

I think it is necessary to block out echos.

TheJJ commented 10 years ago

this can especially be a problem with multiple bots, indeed..

TheJJ commented 10 years ago

why do you think that happens? does umurmur behave differently than murmurd does?

m13253 commented 10 years ago

why do you think that happens? does umurmur behave differently than murmurd does?

Perhaps umurmur sends the message back to the sender. So the bot is receiving what he said. And I have only one bot.

m13253 commented 10 years ago

I have made some modification in my fork https://github.com/m13253/sftmumblebot fixing this problem and another problem that gtfo does not really terminates the program. I did this by adding a comment <!--sft--> before the message body. If the bot received a message beginning with <!--sft--> it will consider it an echo and simply ignore it.

waaaaargh commented 10 years ago

IMHO this isn't the way to do it. The bot is aware of its username in mumble and IRC, so filtering for messages the bot sent itself should be trivial, even without manipulating the message. Please consider opening a pull request with your changes.

Hack on!