search

SFTtech / sftmumblebot

Mumble/IRC text chat bridge :microphone: :love_letter:
GNU General Public License v3.0
49 stars 16 forks source link

Fixed SSL Certificate Support #20

Open JmactheAttack opened 9 years ago

JmactheAttack commented 9 years ago

Added fixes for using personal self-signed SSL certificates to the bot. This will allow users of the script to register their bot as a member of the server. I also added instructions to the README for generating self-signed certificates. If you have any questions or comments, I'm sitting on Freenode as JmactheAttack.

TheJJ commented 9 years ago

Thanks for your patches!

Can you make them a bit more advanced to allow users to select the authentication method (e.g. protocol TLSv1.2, ...) and certificates? Just commenting out the old way isn't the way to go. You can add another argparse or config option for that so everyone can select the verification method needed for his scenario.

JmactheAttack commented 9 years ago

Thanks for the feedback. I'm working on reordering the connection tries so that if the certificate and key pair are not present in the config, it will fail down to the regular connection method. As far as giving a choice between the authentication methods goes, do you see any reason it should be fancier than just "are certificates present in the certfile and keyfile fields, if not, fallback to previous method"?

Side-question: If I continue to commit to my master branch, will it continue to update this pull request, or would I have to close and then remake the pull in the future?

TheJJ commented 9 years ago

we should have optional client certificates (with documentation in the config template) and also ca cert pinning. if these options are empty in the config, then they are inactive.

an option insecure could also be nice to accept just anything.