search

SFU-Blueprint / Pedals

Apache License 2.0
2 stars 0 forks source link

/manage/people Radio button + Filtering Bugs #78

Closed terry9041 closed 1 week ago

terry9041 commented 4 weeks ago

Problems

  1. After clicking "UNDER 18" or "INACTIVE" radio button to filter results, when the result is empty, "SELECT ALL" radio button is still automatically checked. It should not be checked as it confuses the user.

image

  1. After checking "SELECT ALL" option, the option cannot be turned off by clicking the "SELECT ALL" text.

Instructions

  1. Pull the latest changes from the developbranch.
  2. Start the server by running npm run dev (if necessary, navigate to the src/ folder and run npm ci first). Navigate to localhost:3000/manage/people
  3. Modify the logic of the radio button to fix the above issues.
  4. Submit a pull request and tag @dangminhduc1101 for review.
dangminhduc1101 commented 1 week ago

Fixed with #bcbaebf