search

SFX-WoW / Masque

A button-skinning engine for World of Warcraft.
Other
48 stars 11 forks source link

Question: Coloring on Shadowlands Skin #269

Closed nancikennedy closed 1 year ago

nancikennedy commented 2 years ago

Game Flavor

Retail

Game Version

10.0.0.46366

Add-On Version

10.0.1 Beta

Description

The custom color settings for the Shadowlands skin reset to the default when I installed the 10.0.1 Beta version of Masque. While they can be changed back in the settings, the color choices don't actually get applied anymore.

-The default masque skins were not affected. -The two other skins I have installed, Cainyx & Retina, were also not affected.

Error Message

No error message

Steps to Reproduce

Install the new addon Launch WoW

Screenshots

No response

Notes

No response

StormFX commented 2 years ago

I'll look into it.

StormFX commented 1 year ago

@nancikennedy I've been unable to reproduce this.

nancikennedy commented 1 year ago

B4 v4.13.3 M v10.0.1-Beta Slands v 9.0.2

I figured out why I was seeing this. The Bartender bars are only getting the color applied to buttons that have that slot filled. Empty slots are showing as the default Shadowlands color. The bars I was looking at when I reported this were all empty at the time. I have Button Grid enabled on all the B4 bars, and am not hiding the borders on any of them

1st Row: Bartender Bars [1st: Partially filled, 2nd: Empty & 3rd: Partially filled, using Hex] 2nd Row: Farming Bar, empty.

The 3rd Bartender bar and the Farming Bar are acting as I would expect, but not the other two.

Bartender

StormFX commented 1 year ago

The Shadowlands skin has a different texture and color set for empty buttons. If a button is empty, Masque checks to see if the skin has an empty texture. If it doesn't, it uses the Normal texture. The same applies to the color. If it's empty, it uses the skin's empty color if set, if not set, it uses the currently selected color for the Normal texture.

To solve this you can comment out the empty color (and if you want, the empty texture) in the skin file:

Line 64 from:

        EmptyColor = { 1, 1, 1, 1 }

To:

        -- EmptyColor = { 1, 1, 1, 1 }

Basically, just add two dashes before "E" in EmptyColor. The same with EmptyTexture (line 63) if you want.

nancikennedy commented 1 year ago

Got it. Didn't realize that as I'd always had full bars before. Thanks for the help.