SFX-WoW / Masque

A button-skinning engine for World of Warcraft.
Other
48 stars 11 forks source link

Bug: Default Skin Size is Incorrect #273

Closed kstange closed 1 year ago

kstange commented 2 years ago

Game Flavor

Retail

Game Version

10.0.0

Add-On Version

10.0.1

Description

In Masque 10.0.1 with the default scaling settings, if I select the Disable option for a group or select the Default skin, it ends up making the buttons overflow their container and overlap rather than correctly show the default appearance. If the Disable option is checked on initial load, the buttons look normal.

Error Message

No response

Steps to Reproduce

No response

Screenshots

Masque "Default" or post-UI load Disabled state:

image

Disabled state on initial UI load:

image

Notes

As with my other issues, I am seeing this with my mod applying the skin to the native action bars, but I suspect this is related to reverting to the "classic scaling" without updating the skin.

StormFX commented 2 years ago

The default action buttons, at their native size are 45 x 45 in Dragonflight. Reverting the scaling reduced the scale factor to 36, therefore the size every skin is increased by 25% when applied to those buttons (45/36 = 1.25). Eg, an icon whose skin definition is 36 x 36 will be scaled up to 45 x 45. The Default Dragonflight skin is defined with 45 as the base, so it gets increased to ~56 x 56.

I'll see if I can get it to look/work right by scaling down the skin, though I'll have to modify quite a few regions that have SetAllPoints enabled.

Xugos commented 2 years ago

I don't have an issue per say, however I had just updated as of 10/30/22 8PM central time and when I logged in the buttons were smaller. I looked to see if elvui did something to adjust it. After 10 mins I figured out what changed. So if anyone comes here trying to understand why there buttons are smaller now. Check under /msq -> General settings -> interface and check the classic scaling on or off to see if that corrects your issue.

Hopefully this helps someone coming here with a similar concern. :)

StormFX commented 2 years ago

@Xugos The upcoming release (now in beta) reverses the change that caused that and removes that option, just so you know.

Xugos commented 2 years ago

oh ok :)