SFX-WoW / Masque

A button-skinning engine for World of Warcraft.
Other
47 stars 11 forks source link

Bug: Mask Issue on Non-Item Buttons #359

Closed sfmict closed 5 months ago

sfmict commented 5 months ago

Game Flavor

Retail, Classic Era, Classic Wrath

Game Version

10.2.6

Add-On Version

10.2.6

Description

Hi, very cool addon, but...

-- Disable the bag slot mask in 10.0 to enable custom masks.
if CircleMask then
    local Icon = Button.icon

    if Icon then
        Icon:RemoveMaskTexture(CircleMask)
    end

    CircleMask:SetTexture()
end

This code (CircleMask:SetTexture()) disables the icon if not Button.icon for some minimap button addons in my addon

Mb you should use GetNumMaskTextures and GetMaskTexture to disable masks

StormFX commented 5 months ago

A couple of questions:

  1. Which add-on is this affecting?
  2. Why are minimap buttons being passed to Masque?
sfmict commented 5 months ago

1.Rematch 2.My addon uses the masque for skins (HidingBar) 3.I fexed it for my addon, but it's a potential bug

StormFX commented 5 months ago

So your add-on uses Masque for Minimap icons or?

sfmict commented 5 months ago

My addon grabs the minimap buttons and yes uses the masque for them.

StormFX commented 5 months ago

Ok. I'll look into putting something in there to specifically target the bag slots.

sfmict commented 5 months ago

Ahaha, ok) gl)

sfmict commented 5 months ago
if CircleMask then
    local Icon = Button.icon

    if Icon then
        Icon:RemoveMaskTexture(CircleMask)
                CircleMask:SetTexture()
    end
end

mb so

StormFX commented 5 months ago

Like I said, I'll look into it. It may be a bit, though.