search

SFraissTU / BA_PointCloud

PointCloud-BachelorThesis
BSD 2-Clause "Simplified" License
185 stars 42 forks source link

add compatibility with 1.7 and 1.8 Potree format #29

Closed agressin closed 4 years ago

agressin commented 4 years ago

here is the new version that keep compatibility with older format.

SFraissTU commented 4 years ago

Hi! Thanks again for your contribution. I've merged it and edited some of the code, as there were some small issues, such as inconsistent indentation and unnecessary comments or logs. Please see here for details. I didn't change anything regarding the functionality of your code.

agressin commented 4 years ago

Hi, thanks you for cleaning and merging code! I would like to add compatibility with the new 2.X potree format, but I need more time since the format is quite different. I'm not sure if it's better to rewriter the point reader/loader from scratch and loosing compatibility with 1.X format, or to try to modify current code and keep this compatibility...

SFraissTU commented 4 years ago

Hi! That would be great! I think it would be great if compatibility with older versions would be preserved. However I think it would be fine if it would be necessary to have separate types of classes for both versions, e.g. a "PointCloudLoaderPTV1" and a "PointCloudLoaderPTV2", depending on which version of the potree format one wants to use. I'm not familiar with how the newer format works so I cannot provide so much help here at the moment.