Fixed incorrect accuracy assignment in Rinex3NavData from EphemerisGPS

SGL-UT / GPSTk

ATTENTION: This repository has been moved and is for archival purposes only. GPSTk toolkit has been renamed to GNSSTK and has been split into two new separate repositories. GNSSTK now only contains libraries while the other repository GNSSTK-APPS contains only applications. The rename and split into libraries and applications started with version v12.0.0 on September 2021. GPSTk --> GNSSTK at https://gitlab.com/sgl-ut/gnsstk --> GNSSTK-APPS at https://gitlab.com/sgl-ut/gnsstk-apps

Other

342 stars 185 forks source link

Fixed incorrect accuracy assignment in Rinex3NavData from EphemerisGPS #19

Open eugenyk opened 8 years ago

eugenyk commented 8 years ago

We suspect that in Rinex3NavData::operator GPSEphemeris should be accuracy = gpseph.accuracy;

Because

gpseph.accuracy is never used during construction
GPSEphemeris::accuracyFlag is short but Rinex3NavData::accuracy is double And because of description

double accuracy;     ///< SV accuracy (m)

short accuracyFlag;        ///< Accuracy flag (URA)
double accuracy;           ///< Accuracy in meters (from accuracyFlag)

Unit test with conversion check added

masamitsutech commented 6 years ago

Before this pull request can be reviewed for the next stable release, please update the branch to resolve possible merge conflicts.