SGL-UT / GPSTk

ATTENTION: This repository has been moved and is for archival purposes only. GPSTk toolkit has been renamed to GNSSTK and has been split into two new separate repositories. GNSSTK now only contains libraries while the other repository GNSSTK-APPS contains only applications. The rename and split into libraries and applications started with version v12.0.0 on September 2021. GPSTk --> GNSSTK at https://gitlab.com/sgl-ut/gnsstk --> GNSSTK-APPS at https://gitlab.com/sgl-ut/gnsstk-apps
Other
339 stars 182 forks source link

License is LGPL, but current cmake config creates a static library on Windows #24

Open rconde01 opened 7 years ago

rconde01 commented 7 years ago

Statically linking violates the LGPL in the case the library is linked with proprietary code and the source of the proprietary code is not delivered:

http://stackoverflow.com/questions/10130143/gpl-lgpl-and-static-linking

For this reason, it probably makes sense to change the default cmake config to generate a shared library on windows. Since this is already the case for non-windows platforms, I would guess the issue is maybe that symbols aren't exported by default with Visual Studio and it was not desired to decorate the classes. In this case, cmake has a solution:

https://cmake.org/cmake/help/v3.4/prop_tgt/WINDOWS_EXPORT_ALL_SYMBOLS.html

Another alternative is to make an exception in the license (although I'm unsure if gpstk is using other LGPL code that would prevent this).