ATTENTION: This repository has been moved and is for archival purposes only. GPSTk toolkit has been renamed to GNSSTK and has been split into two new separate repositories. GNSSTK now only contains libraries while the other repository GNSSTK-APPS contains only applications. The rename and split into libraries and applications started with version v12.0.0 on September 2021. GPSTk --> GNSSTK at https://gitlab.com/sgl-ut/gnsstk --> GNSSTK-APPS at https://gitlab.com/sgl-ut/gnsstk-apps
In function:
bool RationalizeRinexNav::writeOutputFile
in file
core/lib/GNSSEph/RationalizeRinexNav.cpp
there is no return at the end (around line 131 of the file).
The function compiles OK but quality check on openSUSE build system catches this:
...
[ 114s] I: Program returns random data in a function
[ 114s] E: gpstk no-return-in-nonvoid-function /home/abuild/rpmbuild/BUILD/GPSTk-2.10.6/core/lib/GNSSEph/RationalizeRinexNav.cpp:132
...
as it may return random data, making the program unstable. This error is treated so serious, that built binaries are discarded.
Earlier this function returns false if something happened. Should it return true if it reaches the end?
UT-dave
commented
3 years ago
In function: bool RationalizeRinexNav::writeOutputFile in file core/lib/GNSSEph/RationalizeRinexNav.cpp there is no return at the end (around line 131 of the file). The function compiles OK but quality check on openSUSE build system catches this: ... [ 114s] I: Program returns random data in a function [ 114s] E: gpstk no-return-in-nonvoid-function /home/abuild/rpmbuild/BUILD/GPSTk-2.10.6/core/lib/GNSSEph/RationalizeRinexNav.cpp:132 ... as it may return random data, making the program unstable. This error is treated so serious, that built binaries are discarded. Earlier this function returns false if something happened. Should it return true if it reaches the end?