Open SGTech08 opened 4 months ago
0.92/1
What you have:
You seem to have everything required for this individual check. You have the respected screenshots and have a good video. All the requirements seem meet and issue is easy to read.
What you can make better:
Somethings I see that you can add is explanations below each screenshot explain what it shows and what it does. This would make it easier for less knowledgable coders to understand
More things about what you have done this project would be nice to see. Key commits along with what parts of the project you worked on would be nice.
A condensed project overview or intro would be nice as you right away get into the code of the project before we know what it is about.
In-depth review of code:
Your first screenshot shows your input by adding an event listener to a search button and is well shown. A screenshot of your screen bar on frontend would help. Needs improvement https://private-user-images.githubusercontent.com/142445413/307903674-3f605193-e5ac-4136-9aa7-5053530a5d65.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MDkyMzA0MTQsIm5iZiI6MTcwOTIzMDExNCwicGF0aCI6Ii8xNDI0NDU0MTMvMzA3OTAzNjc0LTNmNjA1MTkzLWU1YWMtNDEzNi05YWE3LTUwNTM1MzBhNWQ2NS5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjQwMjI5JTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI0MDIyOVQxODA4MzRaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT1hNDE2ZTFkNDE0N2QzZjJjNTVmN2YzZjViYWUyMmY4OGRhYzA0YzhhZDQ2ZDBiYTFkNzUxNjk1NDg5ZjRlYWI5JlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCZhY3Rvcl9pZD0wJmtleV9pZD0wJnJlcG9faWQ9MCJ9.JrdYu7pSzskUWhkfTpKNRemZ6_fj4zXwo3kSaFx3-KU
Your second screenshot doesn't show a list but rather making each of these into your sqlite database. A different screenshot of a list is needed. Needs to be changed
Your third screenshot of _getHouses shows you using your api and getting that info. Good
Your fourth screenshot shows and if and a for. If you have > 0 house count then it runs. For all your houses that you have it takes info like bedrooms, price and more. Good
Your fifth screenshot shows you calling a student feature and is fine but a better screenshot could be used like it being called and updated. Needs improvement
Your Sixth screenshot shows the output for when you click on a home. It takes the info from the api and fills in price, rooms and more. Good
Video deep review:
Your video is short, slow and has very little writing.
Your video only shows your login and search but doesn't show favourites and it being saved in your sqlite.db.
In your video it seems like you are stalling and don't know what to show but there is so much you are missing. Showing favourites and it being updated on your backend should be shown.
When showing the sqlite.db (that I recommended) you should explain how favourites are saved to each user and show it updating.
Overview:
Overall you have meet the requirements have an easy to read blog and have an easy to watch and understand video justifying my grading of 0.92/1. You have somethings you could add but this issue is meeting requirements and more.
Feature : Front page with all the properties w/ details
Correlation to CPT
Input:
Allows for a search bar to iterate through the houses. Finds the house you want where you can click view details.
Use of one list:
Correlates the usage of list and makes an api with the houses from the database.
One procedure that contributes to the program’s intended purpose
Allows users to explore houses that they are trying to invest in or just view the details for fun
An algorithm that includes sequencing, selection, and iteration
Iterates through the database to make a list and api. Iterates through the database to display it ui friendly on the front page where users can view details.
Calls to your student-developed procedure
Instructions for output User is provided output with the view details and the search feature. using the search feature it iterates through the properties to find the right one the user wants.
Video
https://github.com/SGTech08/student/assets/142445413/7fd0d1bd-72fd-4972-ad63-736309188462