SGpp / DisCoTec

MPI-based code for distributed HPC simulations with the sparse grid combination technique. Docs->(https://discotec.readthedocs.io/)
https://sparsegrids.org/
GNU Lesser General Public License v3.0
8 stars 7 forks source link

[JOSS] Contributing and authorship #128

Closed EmilyBourne closed 2 months ago

EmilyBourne commented 3 months ago

Regarding https://github.com/openjournals/joss-reviews/issues/7018 - "Contribution and authorship: Has the submitting author (@freifrauvonbleifrei) made major contributions to the software? Does the full list of paper authors seem appropriate and complete?"

I noticed on the contributors page that there seem to be 10 authors of the code (of which at least 4 seem to be major authors): image

but there are only 3 authors of the paper. I can identify the first 2 authors. Is @hurlerml Dirk Pflüger? Is it normal that Michael Obersteiner (@obersteiner ) is not listed as an author?

freifrauvonbleifrei commented 3 months ago

as far as I know, @hurlerml (a student contributor) is not at Uni Stuttgart any more, so I don't know if he'll react. But looking at the contributors page, I would agree that both @hurlerml and @obersteiner should both at least have the chance to be authors.

@hurlerml @obersteiner would you like to? -> current paper draft is here: https://github.com/SGpp/DisCoTec/blob/feature_joss_submission/paper.md (authors can be added in the metadata)

hurlerml commented 3 months ago

Thank you for reaching out and for considering me as an author. I'm glad to hear that the code is being published to the Journal of Open Source Software. I would be happy to be mentioned. Please feel free to include me as an author.

Best regards, Marcel

Am 22.08.2024 um 01:45 schrieb Freifrau von Bleifrei @.***>:

as far as I know, @hurlerml https://github.com/hurlerml (a student contributor) is not at Uni Stuttgart any more, so I don't know if he'll react. But looking at the contributors page, I would agree that both @hurlerml https://github.com/hurlerml and @obersteiner https://github.com/obersteiner should both at least have the chance to be authors.

@hurlerml https://github.com/hurlerml @obersteiner https://github.com/obersteiner would you like to? -> current paper draft is here: https://github.com/SGpp/DisCoTec/blob/feature_joss_submission/paper.md (authors can be added in the metadata)

— Reply to this email directly, view it on GitHub https://github.com/SGpp/DisCoTec/issues/128#issuecomment-2303302598, or unsubscribe https://github.com/notifications/unsubscribe-auth/AFQHBAUOFCF34CLANTLPBXDZSURABAVCNFSM6AAAAABMXGMW6OVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGMBTGMYDENJZHA. You are receiving this because you were mentioned.

freifrauvonbleifrei commented 3 months ago

@hurlerml , I just saw your comment now, happy to hear from you! I just added you to the authors, let me know in case you want an ORCID added :)

freifrauvonbleifrei commented 2 months ago

Yay, with commit 65a03913b658370a9787987991dd854b8683960e we have added all major contributors!