add haptic feedback to buttons

SHA2017-badge / Firmware

ESP32 firmware for the SHA2017 badge

https://wiki.sha2017.org/w/Badge

Other

83 stars 36 forks source link

add haptic feedback to buttons #190

Closed oe1rfc closed 2 months ago

oe1rfc commented 7 years ago

This patch adds haptic feedback to buttons by turning on the vibration motor for 70ms after each button press. This is busy sleep (as a PoC), but even with the added lag limited user acceptance tests have been good so far.

Roosted7 commented 7 years ago

Thanks for your pr!

I like the idea of the haptic feedback, but i think the implementation could be better.

The input lag is quite a disadvantage and could be fixed by making the buzzer call non-blocking
Some games might not value the haptic feedback, so i think this should be optional
We have a hardware #oops since we forgot a reverse diode on the buzzer... We might break transistors if we start switching them a lot. What does @MarkusBec think of this?

Roosted7 commented 7 years ago

(Oops that was the wrong button, did not want to close it!)

basvs commented 7 years ago

@Roosted7 I don't have any problems with this blocking style. But there are still some issues to be resolved. I really like the idea of haptic feedback.

annejan commented 7 years ago

Would be nice to have it switchable (with an NVS setting) that should stop UX headaches like @Roosted7 mentioned..