search

SHA2017-badge / micropython-esp32

MicroPython ported to the SHA2017 badge
https://micropython.org/
MIT License
12 stars 16 forks source link

Added small, simple alternative GUI library (freedomgfx), which respects all four freedoms #208

Closed chca42 closed 7 years ago

basvs commented 7 years ago

Instead of defining a new buffer, why not use the badge_eink_fb buffer?

If you use 1 byte per pixel, you can use ugfx and freedomgfx at the same time and have a few KB extra free memory. (use the DISPLAY_8BITPIXEL flag when using badge_eink_display())

chca42 commented 7 years ago

@raboof The header has been removed in the latest commit, it is not required. @basvs Yes, that makes sense. It has been changed accordingly in the latest commit.

chca42 commented 7 years ago

@basvs Thank you very much for your effort to suggest improvements in code quality. Your points make sense. I made the required changes in the latest commit.

basvs commented 7 years ago

it might be easier to just build the range check in the PX() itself.

chca42 commented 7 years ago

@basvs I have now added a range check to the macro.