SHA2017-badge / micropython-esp32

MicroPython ported to the SHA2017 badge
https://micropython.org/
MIT License
12 stars 16 forks source link

Cut off strings too long to show in ugfx.List #221

Closed DigitalBrains1 closed 7 years ago

DigitalBrains1 commented 7 years ago

This relates to pull request #216. @basvs wrote:

I guess we need to disable the 'center vertically' in C code.

This patch does exactly that. Since this patch is already very useful on its own, I created a new pull request for it.

I'm not too sure about the #ifdef GDISP_NEED_CLIP, though it will compile without it defined, it will render very wrongly. Maybe compilation should fail, perhaps with an error pragma?

DigitalBrains1 commented 7 years ago

Oh, by the way, the MIN() macro does double evaluation of its arguments, but that's not a problem here. I'm not too fond of it though, which is why I'm mentioning it.

basvs commented 7 years ago

I've added my alternative pull-request here: https://github.com/SHA2017-badge/micropython-esp32/pull/222