search

SHA2017-badge / micropython-esp32

MicroPython ported to the SHA2017 badge
https://micropython.org/
MIT License
12 stars 16 forks source link

Only draw the screen when not starting any services. #238

Closed basvs closed 6 years ago

Roosted7 commented 6 years ago

After the PR the splash does not update unless services are active or the splash is going to sleep

basvs commented 6 years ago

Hmm, did you test it with all 3 commits? (see my comments on irc) I was hoping I fixed that in the last 2 commits this afternoon. But I have to admit I didn't have any time to test the new commits.

Roosted7 commented 6 years ago

I tested your branch and it's not fixed. I assume the variable 'have_services' does not report back what your code expects?

On Sat, 3 Mar 2018, 23:04 basvs, notifications@github.com<mailto:notifications@github.com> wrote:

Hmm, did you test it with all 3 commits? (see my comments on irc) I was hoping I fixed that in the last 2 commits this afternoon. But I have to admit I didn't have any time to test the new commits.

— You are receiving this because your review was requested.

Reply to this email directly, view it on GitHubhttps://github.com/SHA2017-badge/micropython-esp32/pull/238#issuecomment-370183483, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AFvYoPBlIgucHLzR9gRgK0VtNaxP2c0Qks5taxNVgaJpZM4SSbar.

basvs commented 6 years ago

hmm, did some testing, but the patch seems to work as intended.. But I did have some problems with the build-system. I had to do a full rebuild to repack the python modules. (it didn't pick up changes in these files)