SHADE-AI / daidepp

Repo to store universal communication specification
2 stars 7 forks source link

Province name mismatches between DAIDE and the diplomacy game engine #61

Open Jacob-Le opened 1 year ago

Jacob-Le commented 1 year ago

The three letter code for certain provinces do not match between the daidepp grammar and the diplomacy game engine.

The ones I have encountered thus far are (diplomacy/daidepp):

Encountering one of the diplomacy engine version of the province names causes the parser to crash. This is slightly inconvenient as we have to do some extra translation between DAIDE and diplomacy. Translating from the diplomacy engine to DAIDE for ENG is particularly thorny because it could be referring to either the english channel or England the power.

aphedges commented 1 year ago

I'd like to point out that you accidentally swapped the values for the Gulf of Lyon. diplomacy uses LYO while daidepp uses GOL. We discovered this when trying to implement a workaround based on this issue.