search

SHADE-AI / daidepp

Repo to store universal communication specification
2 stars 7 forks source link

hotfix: fixed some import errors and an improper type in MoveByCVY #95

Closed mjspeck closed 1 month ago

mjspeck commented 1 year ago

The daide_seas attribute should be a container of location objects, not strings.

aphedges commented 1 year ago

I'm very concerned about this. It breaks backwards compatibility very close to the deadline, and it doesn't align with the grammar. In addition, you approved my change to make the behavior this way.

At the very least, can you please add automatic conversion of string arguments like I did elsewhere?

aphedges commented 1 year ago

In addition, if I'm not mistaken, this will allow coasts to be added. This means that the grammar cannot parse some DAIDE strings created from this object.

mjspeck commented 1 year ago

Yeah, that's fair. I'll keep this out of the main branch and do a workaround in our code.

I'm very concerned about this. It breaks backwards compatibility very close to the deadline, and it doesn't align with the grammar. In addition, you approved my change to make the behavior this way.

At the very least, can you please add automatic conversion of string arguments like I did elsewhere?

aphedges commented 1 year ago

Thank you very much!