search

SHISME / react-native-draggable-grid

A draggable and sortable grid of react-native
320 stars 95 forks source link

Implement RTL language support in draggable grid #91

Closed faizanu94 closed 8 months ago

faizanu94 commented 9 months ago

This PR introduces support for Right-to-Left (RTL) languages in the react-native-draggable-grid package, addressing the issues outlined in #90. It ensures that item ordering and drag-and-drop behavior are correctly handled in RTL mode, improving the user experience and accessibility for RTL language apps. The changes include adjustments to item ordering logic and enhancements to drag-and-drop functionality to align with the natural reading and interaction patterns of RTL users

PPHelios commented 8 months ago

@faizanu94 Thank you for addressing this issue ,but as this fix is not merged yet I tried copying your modifications in draggable-grid.tsx to the same file in my node modules, but it still behaves in the same way, how can i implement it? Thanks in advance

SHISME commented 8 months ago

Thanks for the mr, i had published it on 2.2.0 @PPHelios

PPHelios commented 8 months ago

Thank you for the great library and fast response, but unfortunately as I mentioned earlier this fix is not working for me, as you can see in the attached video the x axis is still reversed in rtl. Any suggestions?

https://github.com/SHISME/react-native-draggable-grid/assets/103271591/793ee257-0f7e-407a-b27b-bdae68823fc6

SHISME commented 8 months ago

Thank you for the great library and fast response, but unfortunately as I mentioned earlier this fix is not working for me, as you can see in the attached video the x axis is still reversed in rtl. Any suggestions?

SVID_20240326_161916_1.mp4

ok， i will check it

faizanu94 commented 8 months ago

Hi @SHISME I've fetched the latest published version of this library (2.2.0 which you recently published) and it doesn't contain the changes implemented in this PR. Can you republish it again?

unpkg: https://unpkg.com/browse/react-native-draggable-grid@2.2.0/built/src/draggable-grid.js

SHISME commented 8 months ago

Hi @SHISME I've fetched the latest published version of this library (2.2.0 which you recently published) and it doesn't contain the changes implemented in this PR. Can you republish it again?

unpkg: https://unpkg.com/browse/react-native-draggable-grid@2.2.0/built/src/draggable-grid.js

Sorry, long time not pulished, i forgot build before publish

you can try with 2.2.1 @PPHelios