SHIV5T3R / CO-DE

An Open Source Collaborative Code Editor
35 stars 26 forks source link

Fix/loading screen #15

Closed DynamiteBob17 closed 1 year ago

DynamiteBob17 commented 1 year ago

A fix for this pull request.

Before

loading screen before fix gif

After

loading screen after fix gif

DynamiteBob17 commented 1 year ago

@blackmouse572

Look good, just need a little refactor.

Oh okay, what would I need to refactor? 😃

blackmouse572 commented 1 year ago

Check the review please. Decouple the theme check to become usetheme hook.

Vào 16:41, T.4, 9 Th8, 2023 Jan Mlinarić @.***> đã viết:

Look good, just need a little refactor.

Oh okay, what would I need to refactor? 😃

— Reply to this email directly, view it on GitHub https://github.com/SHIV5T3R/CO-DE/pull/15#issuecomment-1671002460, or unsubscribe https://github.com/notifications/unsubscribe-auth/ASMSBB7LX7FYUATWGWKL5UDXUNLMVANCNFSM6AAAAAA3JFSWQE . You are receiving this because you commented.Message ID: @.***>

SHIV5T3R commented 1 year ago

@DynamiteBob17 There's a conflict here

DynamiteBob17 commented 1 year ago

@SHIV5T3R ok, will resolve the conflicts hopefully till the end of the day if i find the time