Closed KingXP-Pythoner closed 8 months ago
These changes seem to improve the general code quality and styling consistency. Some of the changes, like switching from single quotes to double quotes, adding missing semicolons and brackets, seem a bit unnecessary, but it's fine by me. However, I encountered an issue when running the PR code locally: it appears that accessing the editor page now redirects to the sign-in page, which results in an
ERR_BAD_REQUEST
error when trying to sign in (I used test values frombackend/tests/test_auth.py
).
I didn't add the .prettierrc.json configurations though so that's not the fault of my PR as I simply worked on the updated fork. For running the sign-in page I didn't work on that either but make sure you have in the root frontend folder the .env file with the correct base url
I didn't add the .prettierrc.json configurations though so that's not the fault of my PR as I simply worked on the updated fork.
Oh, Prettier did automatically, I see. I wonder why it didn't do the same with my code, but whatever.
For running the sign-in page I didn't work on that either but make sure you have in the root frontend folder the .env file with the correct base url
I have .env
file with VITE_BASE_URL="http://localhost:3000"
in the root frontend folder and it still doesn't work.
I didn't add the .prettierrc.json configurations though so that's not the fault of my PR as I simply worked on the updated fork.
Oh, Prettier did automatically, I see. I wonder why it didn't do the same with my code, but whatever.
For running the sign-in page I didn't work on that either but make sure you have in the root frontend folder the .env file with the correct base url
I have
.env
file withVITE_BASE_URL="http://localhost:3000"
in the root frontend folder and it still doesn't work.
This is something that might have to be investigated in another PR. I've only worked on fixing UI stuff mainly in this PR. I believe @SHIV5T3R is also running into issues with signing in😪
This is something that might have to be investigated in another PR. I've only worked on fixing UI stuff mainly in this PR. I believe @SHIV5T3R is also running into issues with signing in😪
But how did you access the editor when working on this PR? Did you not have to sign in?
This is something that might have to be investigated in another PR. I've only worked on fixing UI stuff mainly in this PR. I believe @SHIV5T3R is also running into issues with signing in😪
But how did you access the editor when working on this PR? Did you not have to sign in?
I didn't sign in, I simply commented out AuthGate
in the router lol.
Main Changes
theme
was added and used the editor theme to toggle. I was unable to change the background color to match the consistent theming for our dark mode because it seems they are using a shadow dom and I've got no clue how to manipulate the css yet as they dont have a prop to change the default. I've also cleaned up the logic with the useStateshowPicker
and used the shadcn Popover component instead. This is to ensure consistency in the way we apply coding logic and reusing components.chatBox
was replaced with shadcnTextarea
component and the existing styling to allow the emoji and send button was restyled as there was an easier way to do it with tailwind.button
html element with the shadcnButton
component. (To ensure consistent theming).TabTray
component instead as I think this is more appropriate for UI/UX.ScrollAreaWithMask
component which is just theScrollArea
component of shadcn but with a bottom mask effect that gives a flush transition.Minor changes
side
props of the Popovers in theActivityBar
component to right which is similar to what vscode has and is useful for UX reasons.^
inpackage.json
file.index.css
for a cleaner separator