SHIV5T3R / CO-DE

An Open Source Collaborative Code Editor
36 stars 26 forks source link

UI Bug Fixes & Theming consistency reconciliation to PR #55 #59

Closed KingXP-Pythoner closed 8 months ago

KingXP-Pythoner commented 9 months ago

Main Changes

Minor changes

KingXP-Pythoner commented 9 months ago

These changes seem to improve the general code quality and styling consistency. Some of the changes, like switching from single quotes to double quotes, adding missing semicolons and brackets, seem a bit unnecessary, but it's fine by me. However, I encountered an issue when running the PR code locally: it appears that accessing the editor page now redirects to the sign-in page, which results in an ERR_BAD_REQUEST error when trying to sign in (I used test values from backend/tests/test_auth.py).

I didn't add the .prettierrc.json configurations though so that's not the fault of my PR as I simply worked on the updated fork. For running the sign-in page I didn't work on that either but make sure you have in the root frontend folder the .env file with the correct base url

savvy-itch commented 9 months ago

I didn't add the .prettierrc.json configurations though so that's not the fault of my PR as I simply worked on the updated fork.

Oh, Prettier did automatically, I see. I wonder why it didn't do the same with my code, but whatever.

For running the sign-in page I didn't work on that either but make sure you have in the root frontend folder the .env file with the correct base url

I have .env file with VITE_BASE_URL="http://localhost:3000" in the root frontend folder and it still doesn't work.

KingXP-Pythoner commented 9 months ago

I didn't add the .prettierrc.json configurations though so that's not the fault of my PR as I simply worked on the updated fork.

Oh, Prettier did automatically, I see. I wonder why it didn't do the same with my code, but whatever.

For running the sign-in page I didn't work on that either but make sure you have in the root frontend folder the .env file with the correct base url

I have .env file with VITE_BASE_URL="http://localhost:3000" in the root frontend folder and it still doesn't work.

This is something that might have to be investigated in another PR. I've only worked on fixing UI stuff mainly in this PR. I believe @SHIV5T3R is also running into issues with signing in😪

savvy-itch commented 9 months ago

This is something that might have to be investigated in another PR. I've only worked on fixing UI stuff mainly in this PR. I believe @SHIV5T3R is also running into issues with signing in😪

But how did you access the editor when working on this PR? Did you not have to sign in?

KingXP-Pythoner commented 9 months ago

This is something that might have to be investigated in another PR. I've only worked on fixing UI stuff mainly in this PR. I believe @SHIV5T3R is also running into issues with signing in😪

But how did you access the editor when working on this PR? Did you not have to sign in?

I didn't sign in, I simply commented out AuthGate in the router lol.