search

SHIV5T3R / CO-DE

An Open Source Collaborative Code Editor
36 stars 26 forks source link

Underscore in password regex missing #60

Open KingXP-Pythoner opened 8 months ago

KingXP-Pythoner commented 8 months ago

I'm not sure if it was intentional or not but it is not possible to create an account using a password with underscores. I believe new user should be allowed to do this.

MrBisquit commented 8 months ago

I'm not sure I've ever seen a password use underscores in it.

KingXP-Pythoner commented 8 months ago

It makes no sense to me to prohibit it. I don't think there's even any popular security convention that says to prohibit it. Users should be able to formulate their passwords however they want as long as the basic guards are set in place like minimum of 8 characters and so on

MrBisquit commented 8 months ago

It makes no sense to me to prohibit it. I don't think there's even any popular security convention that says to prohibit it. Users should be able to formulate their passwords however they want as long as the basic guards are set in place like minimum of 8 characters and so on

Yeah, but I'm not sure anywhere let's you use an underscore in a password.

KingXP-Pythoner commented 8 months ago

It makes no sense to me to prohibit it. I don't think there's even any popular security convention that says to prohibit it. Users should be able to formulate their passwords however they want as long as the basic guards are set in place like minimum of 8 characters and so on

Yeah, but I'm not sure anywhere let's you use an underscore in a password.

I'm sorry what? Literally all my life I've never encountered restriction of underscores. This is becoming an unnecessary point of contention to be honest

zatoa commented 8 months ago

Actually I rarely use the letter 'b' in my passwords. Mind if we block those too?

MrBisquit commented 8 months ago

I mean, if you want to, I don't see why not.

KingXP-Pythoner commented 8 months ago

I mean, if you want to, I don't see why not.

So why were you bringing up some sort of wall against it? That was odd mate.

MrBisquit commented 8 months ago

I mean, if you want to, I don't see why not.

So why were you bringing up some sort of wall against it? That was odd mate.

I'm not, I'm just saying that I've never seen a password with an underscore in it, that's all.

zatoa commented 8 months ago

You can't just edit the comments to suggest something else and pretend what @KingXP-Pythoner was mentioning doesn't exist. Just own up to it and say "Yeah you're right my bad" so when someone else views this thread they don't think @KingXP-Pythoner is making a fuss over nothing.

KingXP-Pythoner commented 8 months ago

You can't just edit the comments to suggest something else and pretend what @KingXP-Pythoner was mentioning doesn't exist. Just own up to it and say "Yeah you're right my bad" so when someone else views this thread they don't think @KingXP-Pythoner is making a fuss over nothing.

Woah, I just noticed the edit 😕👎