search

SHIV5T3R / CO-DE

An Open Source Collaborative Code Editor
34 stars 26 forks source link

Github Authorisation #73

Open KingXP-Pythoner opened 7 months ago

KingXP-Pythoner commented 7 months ago

This PR completes the Github Oauth flow. User can now sign in and out of Github.

Changes:

KingXP-Pythoner commented 7 months ago

The PR is beneficial to the project and solves the stated issues. General recommendations:

  1. Please mention the number of the issue that your PR (GitHub Authorisation #63 ) is focused on somewhere for proper accounting.
  2. The current README instructions are insufficient and prevented me from testing whether the implemented features actually work. Update README or provide more detailed instructions in the PR description, namely step by step instruction on how to locally test GitHub authorization feature.
  1. The issue was closed at the time I submitted the PR, it was only reopened after. However, I'll update.
  2. To test the Github authorisation feature is simply filling up the env variables. I'll do my best to update the README.