search

SHO-ai-org / addon-stitches

Storybook addon that allow the application of
MIT License
4 stars 1 forks source link

Support for Storybook 8 #10

Closed yunyongEthan closed 7 months ago

yunyongEthan commented 7 months ago

First of all, thank you for developing the addon that makes it easy to apply the stitches theme.

I'm configuring Storybook using the multiple-themes-stitches addon. I recently upgraded to Storybook version 8.0.0 and proceeded with the migration. However, I noticed that the peerDependencies you're referring to are configured to only support version 7 of Storybook. (Since it still works fine with Storybook 8, it seems that there shouldn't be a need for significant changes.)

Here's the warning I'm encountering

➤ YN0060: │ @storybook/blocks is listed by your project with version 8.0.0, which doesn't satisfy what multiple-themes-stitches (pd162b) requests (^7.0.0-rc.1).
➤ YN0060: │ @storybook/components is listed by your project with version 8.0.0, which doesn't satisfy what multiple-themes-stitches (p5b6e8) requests (^7.0.0-rc.1).
➤ YN0060: │ @storybook/core-events is listed by your project with version 8.0.0, which doesn't satisfy what multiple-themes-stitches (pda755) requests (^7.0.0-rc.1).
➤ YN0060: │ @storybook/manager-api is listed by your project with version 8.0.0, which doesn't satisfy what multiple-themes-stitches (pc00fb) requests (^7.0.0-rc.1).
➤ YN0060: │ @storybook/preview-api is listed by your project with version 8.0.0, which doesn't satisfy what multiple-themes-stitches (p6fc29) requests (^7.0.0-rc.1).
➤ YN0060: │ @storybook/theming is listed by your project with version 8.0.0, which doesn't satisfy what multiple-themes-stitches (pcffe4) requests (^7.0.0-rc.1).
➤ YN0060: │ @storybook/types is listed by your project with version 8.0.0, which doesn't satisfy what multiple-themes-stitches (p2d1dd) requests (^7.0.0-rc.1).

Note: Your peerDependencies

    "@storybook/blocks": ^7.0.0-rc.1
    "@storybook/components": ^7.0.0-rc.1
    "@storybook/core-events": ^7.0.0-rc.1
    "@storybook/manager-api": ^7.0.0-rc.1
    "@storybook/preview-api": ^7.0.0-rc.1
    "@storybook/theming": ^7.0.0-rc.1
    "@storybook/types": ^7.0.0-rc.1
yunyongEthan commented 7 months ago

Additionally, I'm receiving the following warnings in the console due to the deprecation of Icons from @storybook/components.

Use of the deprecated Icons (paintbrush) component detected. Please use the @storybook/icons component directly. For more informations, see the migration notes at https://github.com/storybookjs/storybook/blob/next/MIGRATION.md#icons-is-deprecated

mathisobadia commented 7 months ago

@yunyongEthan It took a while because the release process was a bit broken but we just release a new version (2.0.3) with the right dependency upgrade. Let me know if it works for you !

yunyongEthan commented 7 months ago

@mathisobadia I applied the new version and it works well without errors. thanks :)