search

SHPE-UTDallas / Website-Redesign

Redesign of the SHPE website
3 stars 2 forks source link

Homepage #35

Closed rigrergl closed 3 years ago

rigrergl commented 3 years ago

Homepage is finalized (for now, we can add stuff if later if we want to)

We can also put the instagram iframe in the homepage instead of the newsletter form (we can discuss this in our next meeting)

gabriel-flynn commented 3 years ago

Also we can save this for another pr but I think we might want to play around with the breakpoints on the newsletter - it looks a little weird on certain screen sizes (I think we could resolve this by making the div it's in smaller so it doesn't stretch as seen in the gif and just have it centered - the whitespace to the left and right of the fields is what makes it look out of place) Gif of the breakpoint/sizing issue

rigrergl commented 3 years ago

Nice. I'll go ahead and merge it now so anabel can start working on her issue. I'll look for replacements for the webp images later this week.

On Sat, Jan 23, 2021 at 7:04 PM Gabriel Flynn notifications@github.com wrote:

@gabriel-flynn requested changes on this pull request.

Looks good! Last thing that needs to be done is merging the dev branch into the homepage branch - looks like there is a merge conflict with the theming/variables.scss file

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/SHPE-UTDallas/Website-Redesign/pull/35#pullrequestreview-574887872, or unsubscribe https://github.com/notifications/unsubscribe-auth/APCW4573IJQZCZVF6TTOW43S3NWZPANCNFSM4WCWMVPQ .