search

SHPE-UTDallas / Website-Redesign

Redesign of the SHPE website
3 stars 2 forks source link

Tech team page #58

Closed rigrergl closed 3 years ago

rigrergl commented 3 years ago

-double check the paragraph at the beginning and the project descriptions (did I miss anything or do you want anything phrased differently)

-Did you want me to expand the important information to be more graphical rather than in a paragraph? (time commitment, meeting time, benefits of joining)

-Let me know what you think of general page layout

rigrergl commented 3 years ago

-I forgot to mention it but I changed the \ tag to be whatever $primary is set to (will apply throughout the website) Let me know if I should change it back

gabriel-flynn commented 3 years ago

@rigrergl I think having the same color for <strong> tags could be nice, maybe we should make a section called Globals in the _variables.scss file that has those css styles that apply to all elements so that way it's obvious what isn't just a css class or id.

Speaking of that variables file - I need to try to find other projects using bulma/scss and see how they have their css stuff architected. I feel like theres probably a better way to do it than having like one big scss file (or that could be best practice for all I know - I'm not super in the know with best front-end practices) but I guess it definitely does make it easier to tell what applies to what

rigrergl commented 3 years ago

@gabriel-flynn Went it and put the <strong> tag override at the top in a section labeled GLOBALS Branch should be good to merge now

And yeah I don't think having all the styling in this one file is best practice either tbh, should we look into a way to reformat this before the MVP deployment next month, or should we leave that for when we're refining the website?

gabriel-flynn commented 3 years ago

@rigrergl are you sure you pushed the changes? I don't see any new commits.

Yeah I think that's definitely a good idea - at the very least we can break down the styling into a per-page type of thing but I'll try to look into what other react/next.js/bulma/whatever projects are using to find a good solution. I think it'd be fine to deploy it as is for the MVP but I'd definitely like to refactor the scss file sooner rather than later so we don't end up with a lot of tech debt

rigrergl commented 3 years ago

@gabriel-flynn Ok yeah my bad I must've lost the changes when I merged with my other branch. The changes should be in now.

By the way we need to change the preview image for the Website-Redesign project on this page cause right now it shows the homepage but it has the broken instagram thing. Whenever we actually fix the instagram component or replace it with the Newsletter component, remind me to change it in case I forget.