SHsuperCM / CITResewn

Fabric implementation of mcpatcher's cit
MIT License
165 stars 91 forks source link

CIT Resewn cannot resolve paths generated by `paletted_permutations` #256

Open Andrew6rant opened 1 year ago

Andrew6rant commented 1 year ago

1.19.4 introduced paletted_permutations, which is a way to dynamically generate new textures in memory (here is some documentation from the snapshot they were introduced in).

Any textures created by these cannot be parsed by CIT Resewn.

For example, here is vanilla Minecraft's iron_chestplate_amethyst_trim model JSON:

{
  "parent": "minecraft:item/generated",
  "textures": {
    "layer0": "minecraft:item/iron_chestplate",
    "layer1": "minecraft:trims/items/chestplate_trim_amethyst"
  }
}

You can use the texture minecraft:trims/items/chestplate_trim_amethyst in resource packs, but setting texture=minecraft:trims/items/chestplate_trim_amethyst in an item's .properties file gives you the error:

{citresewn} Errored while parsing CIT: Cannot resolve path @L20 in minecraft:optifine/cit/armor_trims/iron_chestplate.properties from file/Distinct Armor Trims

Enabling the "Broken Paths" option and restarting does not fix the issue.