search

SHsuperCM / CITResewn

Fabric implementation of mcpatcher's cit
MIT License
154 stars 76 forks source link

[MOD COMPATIBILITY] CIT Textures don't display in item frames when using More Culling's Custom Item Frame Renderer #313

Open KawaiiBakemono opened 11 months ago

KawaiiBakemono commented 11 months ago

Bug

When paired with the More Culling, any CIT texture, when placed in either type of item frame, displays the default item texture.

See bug replication here on YouTube.

Expected Result

The item should retain it's given CIT texture.

Info

Mod Version: 1.1.3 Minecraft Version: 1.20.1 Launcher: Prism Launcher 6.3 Mod Loader: Fabric 0.14.21 OS: Kubuntu Linux

the-n1n commented 10 months ago

That looks like its Entity Culling's Item Frame renderer, I think you need to disable that.

KawaiiBakemono commented 10 months ago

Dang you can tell what renderer it's using? And yes that was the issue, thank you! Should I have this under a compatibility issue instead?

KawaiiBakemono commented 10 months ago

Okay, nevermind! I did some further testing and it seems I had both Entity Culling AND More Culling installed. In this case More Culling was the issue, not Entity Culling. I updated my pack to include instructions to bypass this, which is just a matter of disabling the Custom Item Frame Renderer. Sorry about that! I should've done more testing beforehand haha.

Brancieq-Paul commented 10 months ago

The problem here, the item frame renderer is one of the more important MC optimisations. I don't if it's possible, but it would be nice that CIT Resewn was compatible with the custom item frame renderer