search

SHsuperCM / CITResewn

Fabric implementation of mcpatcher's cit
MIT License
143 stars 71 forks source link

Temperary patch for 1.20.6 #406

Closed DonFlymoor closed 6 days ago

DonFlymoor commented 1 month ago

For now you could take the new conditions and parse them into the old NBT format when applying textures and models, so as not to break compatibility with old resource packs. This would be a relatively simple patch and would allow the mod to continue to work until a decision is reached in https://github.com/sp614x/optifine/issues/7658

shadowtigercool commented 2 weeks ago

any update on this?

Mukul1127 commented 2 weeks ago

This is a good idea

STICKzilla21 commented 1 week ago

Something like this?

type=item
matchItems=name_tag
nbt.custom_name=Dinnerbone
Mukul1127 commented 1 week ago

I think he means to basically ignore the new conditions and instead parse the old ones so older stuff will still work

SHsuperCM commented 6 days ago

The problem is that there is no new format decided yet. If anything nbt. is going away and will be replaced with actual components support. Porting between the two however is not a simple task and would most likely break a lot of resourcepacks which is what I am debating on doing. I'd much rather see optifine spec before moving forwards with this port as the situation is very complicated.

Just be patient.