Suspicious stew, goat horn, compass CIT broken [1.21]

[meowinqq]

Describe the Issue (clear and concise description of what the bug is, provide logs) CIT targeting different suspicious stew effects, different goat horn instruments, and compass lodestone dimensions appear to be non-functional. Expected behavior (Optifine 1.21 pre9):

Suspicious stew effects display custom textures

Goat horns display custom textures

Compass connected to lodestone in the overworld displays custom texture and the animation displays correctly [no example image]

Behavior in CITResewn:

Suspicious stew textures remain default

Goat horn textures remain default

Custom compass texture is displayed, but only the first frame of animation remains functional (arrow stuck pointing forward) [no example image]

Resource pack: test.zip Logs

To Reproduce (if applicable, explain how someone would go about reproducing this issue, attach a resourcepack if applicable)

• Run latest CITResewn beta for 1.21
• Use attached resource pack

Checklist (go through and check these when relevant)

• [x] I have attached the latest.log file relevant to this issue
• [x] I have checked the issues and have not found an existing case of this issue
• [x] I am using the latest version of CIT Resewn for my version of minecraft
• [x] I am using the mod on Fabric Loader
• [x] I have disabled broken paths in the mod's config and the issue persists

[SHsuperCM]

These are 3 separate issues it seems.

• [x] Suspicious Stew The nbt check was not able to match when the root element was a list
• [x] Goat Horns The nbt check used NbtOps instead of the RegistryOps which meant it couldnt match against the id of the horn
• [x] Compass The compass behavior is working as intended.

[normie-chan]

I also have this pack that has custom buckets depending upon the axo in the bucket and it only uses the default one for some reason, gonna hope and assume this getting fixed helps that issue as well because currently it doesn't work. I would hope nothing majorly code wise would've broken the buckets!

[meowinqq]

@normie-chan that pack hasn't been updated to use the component CIT format, nbt data is no longer used in post-1.20.5 CIT -- i was able to get axolotl bucket CIT working just fine w/ the new format in the latest version of this mod! you can update that pack yourself by getting the component data for the buckets (hold one in your hand use the "/data get entity [your username] SelectedItem" command to have its data pasted into the chat) and editing the .properties files accordingly :)

[SHsuperCM]

The compass is working as intended. As per the docs when using a submodel with texture.sub= you need to target the file name in the override.

You had:

texture./compass_01=./compass_01

When it should be

texture.compass_01=./compass_01

(note the sub part is just the sub model's name without the /)

I dont know why it allows the slash in optifine but it does not warrant a parity fix imo as it is an incorrect cit definition.

[SHsuperCM]

Other than that the issues will be fixed in the next beta release (v1.2.1)

[normie-chan]

@meowinqq could you please make a tutorial on how to do so, I am a noob at this lol. Plus I have a custom texture that I'd rather not have to waste because I have 0 clue what to do with this info