components.enchantments not evaluated correctly

[EzranTheDragon]

Describe the Issue components.enchantments. is not working as intended and never results in a texture change.

To Reproduce

• On MC 1.21 or 1.21.1
• Install CIT Resewn, Fabric API and optionally Cloth Config+Mod Menu
• Add and activate the recourcepack Visual_Enchantments_v1.zip
• Enchant a Netherite Pickaxe with Silktouch
• Expectation: The pickaxe is changing the texture, tho it isn't

To see that the Recourcepack itself works comment the components.enchantments out and enable components.custom_name this results in the expected behavior when renaming the Pickaxe. When enabling both components the texture wont change either so they are both accepted as conditions but the enchantment is not fulfilled properly.

enchantments= and enchantmentIDs= work properly.

Hardware/System Information Since it appears to work for @SHsuperCM here more Infos about my system that might help:

• Windows 10 Pro
• 32 GB RAM
• RTX 2070 SUPER (Drivers up to Date)
• Java 21.0.2 Adoptium-Temurin
• no JVM arguments
• prism Launcher

Checklist (go through and check these when relevant)

• [x] I have attached the latest.log file
• [x] I have checked the issues and have not found an existing case of this issue
• [x] I am using the latest version of CIT Resewn for my version of minecraft
• [x] I am using the mod on Fabric Loader
• [x] I have disabled broken paths in the mod's config and the issue persists

[HiWord9]

Same. I tried using only one condition, i tried to copy the condition from preudo-documentation from #447 and gave myself pickaxe enchanted with thorns via command, still does not work. On screen there is custom_name condition, nut before that i also tried with old nbt.Display.Name, i also tried without name condition at all, still no progress. It work only if there is name condition only.

At first i thought that if it is missing cause of beta status there should be announcement, but i could not find any opened issues where said so. So it looks like almost no one else is experiencing the issue.

Minecraft 1.21.1, fabric loader 0.16.5, fabric api 0.104.0+1.21.1, cit resewn 1.2.0. latest.log

Edit: enchantmentIDs worked well if anything

[SHsuperCM]

Ah.. lmao

My bad, I was testing the issue in dev on latest commit and not on the v1.2.0 beta. It appeared fixed for me because this was already fixed for goat horns in #456.

Basically CITs were checking components with NbtOps instead of RegistryOps meaning it saw the silk touch as its encoding instead of as "minecraft:silk_touch".

[SHsuperCM]

Fixed in e009f189 and will be out in the next beta (v1.2.1)