SHsuperCM / CITResewn

Fabric implementation of mcpatcher's cit
MIT License
170 stars 92 forks source link

[OptiFine Parity] Armor trim components fail to match correctly #466

Closed Thanos1716 closed 2 months ago

Thanos1716 commented 2 months ago

The Issue When trying to match armor trim data which is stored in the component minecraft:trim, it is impossible to get it to match. This is in contrast to OptiFine which is able to match it without issue. I am not sure what is causing the discrepancy.

My .properties files look something like the following:

type=item
matchItems=minecraft:chainmail_boots
model=minecraft:item/boots/chainmail/coast/amethyst
components.trim.pattern=minecraft:coast
components.trim.material=minecraft:amethyst

To Reproduce

  1. Install this development build of the Visual Armor Trims resource pack in OptiFine.
  2. Create any piece of armor with a trim (avoid Bolt or Flow, as they are still being tested).
  3. Observe the missing model. Note: it is shown as a missing model in OptiFine because OptiFine is unable to handle the vanilla feature paletted_permutations with CIT models. CIT Resewn can handle them perfectly fine.
  4. Install the same development build in CIT Resewn.
  5. Observe no change in model or texture

latest.log

Checklist

SHsuperCM commented 2 months ago

Same problem as #465, trims are in a registry and it couldnt match against it.

SHsuperCM commented 2 months ago

Fixed in e009f189 and will be out in the next beta (v1.2.1)