SICKAG / sick_safetyscanners

ROS driver for SICK safety laser scanners
https://www.sick.com/de/en/opto-electronic-protective-devices/safety-laser-scanners/c/g187225
Apache License 2.0
61 stars 59 forks source link

feat: Add checksums to diagnostics #126

Closed YannickdeHoop closed 1 year ago

YannickdeHoop commented 1 year ago

Hi @puck-fzi, In this PR i want to add the configuration checksums to the diagnostics. However this checksum will only be read from the device on startup. We may want to poll it because the configuration could be changed, what do you think? In the configuration tool of the nanoscan the checksums are read big endian. So to have the same checksum in the driver we should also read it big endian.

YannickdeHoop commented 1 year ago

ping @puck-fzi

lenpuc commented 1 year ago

Hi, i would say, reading it at startup of the driver might be sufficient for now. If it appears not to be, polling could be added later

lenpuc commented 1 year ago

Merged