Closed guilyx closed 3 years ago
lenpuc
commented
3 years ago Hi, currently this is not on my agenda. But please feel free to open a PR for the lifecycle nodes, I am happy to review it and merge it into the driver it it looks good. In the best case scenario both the lifecycle node and the current not a both on the main branch and can both be used depending on what the user needs.
guilyx
commented
3 years ago Hi, yeah fine. Someone will shoot a PR next week for this.
lenpuc
commented
3 years ago Hi, just a follow up, are you still working on this? if not i would mark it as help wanted
guilyx
commented
3 years ago Hey, I’m sending the PR today!
Le mer. 30 juin 2021 à 13:27, Lennart Puck @.***> a écrit :
Hi, just a follow up, are you still working on this? if not i would mark it as help wanted
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/SICKAG/sick_safetyscanners2/issues/9#issuecomment-871321445, or unsubscribe https://github.com/notifications/unsubscribe-auth/AKMHJVH6PJ55XZLSI3ICAA3TVL5R3ANCNFSM45H72UOA .
lenpuc
commented
3 years ago Corresponding PR #11 has been merged into the master
Hi there,
Is there any plans to use lifecycle nodes for the scanner driver? As it may crash, being able to add this to a lifecycle manager along with controllers and other low level critical packages would prevent any robot from moving if one of the nodes die. Not sure if you're remotely interested in doing this, but if you were I'd be happy to develop this on a parallel branch maybe ?