search

SICKAG / sick_safetyscanners_base

CPP (C++) Driver for SICK safety laser scanners
https://www.sick.com/de/en/opto-electronic-protective-devices/safety-laser-scanners/c/g187225
Apache License 2.0
14 stars 32 forks source link

fix: fix clang warnings. #16

Closed valleymouth closed 1 year ago

valleymouth commented 2 years ago

This should fix https://github.com/SICKAG/sick_safetyscanners_base/issues/9.

sanssecours commented 1 year ago

While I have no idea, if the pull request above breaks something, it seems building the library with LLVM works without any problems, after applying the changes 👍. At least on my machine (macOS 13.1) the following commands:

git clone https://github.com/valleymouth/sick_safetyscanners_base.git -b fix_clang_warnings 'Safety Scanner'
cd 'Safety Scanner'
cmake -G Ninja -B build
cmake --build build

finish successfully.

lenpuc commented 1 year ago

Hi thanks, for contributing, I will have a look through it and integrate it