search

SICKAG / sick_safetyscanners_base

CPP (C++) Driver for SICK safety laser scanners
https://www.sick.com/de/en/opto-electronic-protective-devices/safety-laser-scanners/c/g187225
Apache License 2.0
14 stars 32 forks source link

Please update this repo to stay in sync with sick_safetyscanners #24

Closed mlederhi closed 1 year ago

mlederhi commented 1 year ago

or better remove this repo altogether and provide a CMake switch in repository sick_safetyscanners to build a C++ library independent from ROS.

lenpuc commented 1 year ago

Hi, which feature are you missing? And yes, it would be better if it was one repo. However, the ROS driver was the first development, and it did branch into an independent driver with additional features for async and sync data processing. This base driver is underlying the ROS2 driver. So, from my side, I will integrate features as needed however the ROS1 driver will not be adapted with a standalone CPP option

mlederhi commented 1 year ago

A colleague of mine used the ROS1 driver version some time ago and commented out the ROS stuff so we could use the library in you C++ application. From the maintenance point of view it would have been nice, that we don't have to do this again with new releases of the library. I just thought, that this repo was left behind the ROS1 repo - but since it is based on the ROS2 version, you can probably close this issue.

lenpuc commented 1 year ago

Yes, it should not be left behind, and once ROS1 has its end of life this and the ROS2 driver will be the main components, and if something is missing, please just let me know.