search

SICKAG / sick_safetyscanners_base

CPP (C++) Driver for SICK safety laser scanners
https://www.sick.com/de/en/opto-electronic-protective-devices/safety-laser-scanners/c/g187225
Apache License 2.0
12 stars 32 forks source link

fix compilation with boost 1.7 #3

Closed fay2003hiend closed 3 years ago

puck-fzi commented 3 years ago

Hi, Thanks for your contribution.

Could you please give a brief summary what the pull request is fixing. Furthermore is the fix backwards compatible? Does it still work with earlier versions?

fay2003hiend commented 3 years ago

Hi

this fix is tested compatible with both boost 1.6x (Ubuntu 18.04) and 1.7x (Ubuntu 20.04) by the look of changes I think the impact is zero since it makes use of m_io_service instead of reading a context from m_socket (in 1.7x reading io_context from socket is changed)

fay2003hiend commented 3 years ago

there is a specific line removing boost::ref is because the latter m_deadline_timer constructor does not like wrapped context reference in 1.7x, removal of it should not cause any problem.

puck-fzi commented 3 years ago

I'll test it, and if everything looks fine i'll merge it

puck-fzi commented 3 years ago

Appears to be backward compatible. therefore it was merged

fay2003hiend commented 3 years ago

thank you