search

SICKAG / sick_safetyscanners_base

CPP (C++) Driver for SICK safety laser scanners
https://www.sick.com/de/en/opto-electronic-protective-devices/safety-laser-scanners/c/g187225
Apache License 2.0
12 stars 32 forks source link

add test_async app #4

Closed fay2003hiend closed 3 years ago

puck-fzi commented 3 years ago

Hi, Thanks for your contribution.

Could you please give a brief summary what the pull request is for. Thanks

fay2003hiend commented 3 years ago

Hi

this is to just give user a straight forward working example instead of building a test app from README. also it removes the hassle that user has to at least understand one kind of build system before they can use the library

Entropy512 commented 3 years ago

It looks to me like right now it would always be compiled and isn't enabled/disabled with some sort of cmake directive.

When building this library for use in an embedded system, one doesn't want the test apps included, so the examples need to somehow be made optional as part of the build process.

puck-fzi commented 3 years ago

Due to the current concerns i will not merge it.

However feel free to improve upon the mentioned issues.

puck-fzi commented 3 years ago

I will close the current state of the PR. However feel free to open a new one if the changes are integrated