search

SICKAG / sick_scan_xd

Based on the sick_scan drivers for ROS1, sick_scan_xd merges sick_scan, sick_scan2 and sick_scan_base repositories. The driver supports both Linux (native, ROS1, ROS2) and Windows (native and ROS2).
Apache License 2.0
99 stars 84 forks source link

make MIN MAX defines more unique to avoid "error: invalid use of ‘::'" #207

Closed lucasw closed 7 months ago

lucasw commented 1 year ago

I didn't have an issue building this locally, but inside a github action it wouldn't build without changing the name of MIN() & MAX() (and some help from https://stackoverflow.com/questions/44596168/c-error-invalid-use-of-for-stdcout)


/sick_scan_xd/include/sick_scan/sick_ros_wrapper.h:95:18: error: invalid use of ‘::’```
rostest commented 1 year ago

Thank you very much for your contribution and this PR. It will be integrated in the next release.

lucasw commented 1 month ago

Was this or something similar to accomplish the same think supposed to be merged?

lucasw commented 1 month ago

Ah I see it, there are some commits like https://github.com/SICKAG/sick_scan_xd/commit/b8fabd50d0db2880d643a3d3e2cb5d5db4c436d5