search

SICKAG / sick_scan_xd

Based on the sick_scan drivers for ROS1, sick_scan_xd merges sick_scan, sick_scan2 and sick_scan_base repositories. The driver supports both Linux (native, ROS1, ROS2) and Windows (native and ROS2).
Apache License 2.0
95 stars 85 forks source link

Hardcoded/wrong implementation of the scan topic remaps from 3.0.0 onwards #247

Closed RBinnenmars closed 1 month ago

RBinnenmars commented 8 months ago

From version 3.0.0 onwards, the topic that the laser scan is published changed to the /scan topic. For example, I use the sick_nav_350 lidar, previously this was "/sick_nav_350/scan" (the other topic still has the namespace) but this is hardcoded to the "/scan" topic. This should be done with a launch argument to be remapped to a different topic if wanted, now the topic can only be remapped by also including the namespace (/sick_nav_350/scan:=/wanted_topic).

Also update your package.xml to use the correct version numbers

rostest commented 8 months ago

Thanks for your feedback. We will add a remap option for ros laserscan messages in the launchfile in the next release. Please use ros option <remap from="/sick_nav_350/scan" to="/wanted_topic"/> in the launchfile for remapping laserscan messages.

The version number in package.xml will be updated.

rostest commented 8 months ago

The ros topic for laserscan messages can now be configured directly by using the new branch feature/laserscan_topic. Use commandline argument laserscan_topic:=<topic_name> or launchfile parameter laserscan_topic to overwrite the default laserscan topic.

fmessmer commented 8 months ago

@rostest when will this feature be included in the main branch? it's still only implemented in a feature branch, right? it would be easier for the community to follow the changes of the upstream repo if you would also provide PullRequest from the feature branches to the main branch....otherwise it is hard to see when changes become available because you do not get notifications for commits being pushed without PullRequests

I think the issue should stay open until the patch is included in the main branch!

rostest commented 8 months ago

@fmessmer Thanks for your feedback. This feature is currently only available in branch feature/laserscan_topic. It will be included in the main branch with the next release. We will leave this issue open until then. As an alternative to the new laserscan_topic parameter, you can use ros option <remap from="/sick_nav_350/scan" to="/wanted_topic"/> in the launchfile for remapping laserscan messages.

fmessmer commented 7 months ago

what is blocking to merge the feature branch to the main branch? it is completely backwards-compatible for those that don't want to use it. thus, it could sit on the main branch being merged while waiting for the next main branch release.

rostest commented 7 months ago

@fmessmer Thanks for your feedback. We will clarify it with SICK.

fmessmer commented 7 months ago

I just wanted to create a PullRequest for the mentioned feature branch to increase visibility of getting this merged. But the creation failed because I'm not a collaborator.

I must say: very strange policy for an open-source repo to not accept contributions from the community.

rostest commented 7 months ago

@fmessmer Thanks for your feedback. Please contact SICK support for policy requests.

rostest commented 7 months ago

@fmessmer Pull request #264 is created.

aiplemaSICKAG commented 6 months ago

@fmessmer We welcome contributions from the community and regularly merge contributions from pull requests. Please use the conventional github process for pull requests consisting of creating a fork of the sick_scan_xd repository, applying changes to a branch in that repository and creating a pull request (see https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/proposing-changes-to-your-work-with-pull-requests/creating-a-pull-request-from-a-fork ). Feel free to contact us should you still experience problems when following that process.

fmessmer commented 6 months ago

Now that the feature/PR made it into v3.2.0, do you also plan to trigger a bloom-release for this version on the ROS BuildFarm for noetic

rostest commented 6 months ago

Bloom release for version 3.2.0 is in progress. It has been successfully built on the ros build farm a few days ago (https://build.ros.org/job/Ndev__sick_scan_xd__ubuntu_focal_amd64/4/, git commit https://github.com/SICKAG/sick_scan_xd/commit/abd456030afbdbdc397e17450a99f935014923d2) and should soon be available via apt.