search

SICKAG / sick_scan_xd

Based on the sick_scan drivers for ROS1, sick_scan_xd merges sick_scan, sick_scan2 and sick_scan_base repositories. The driver supports both Linux (native, ROS1, ROS2) and Windows (native and ROS2).
Apache License 2.0
101 stars 84 forks source link

Configuration of laserscan topic #247 #264

Closed rostest closed 7 months ago

rostest commented 8 months ago

This pull request adds an option to configure the laserscan topic by launchfile and will be included in the next release. The PR is created to increase the visibility of branch https://github.com/SICKAG/sick_scan_xd/tree/feature/laserscan_topic, see comment https://github.com/SICKAG/sick_scan_xd/issues/247#issuecomment-1911567061.

fmessmer commented 7 months ago

obviously now part of the master branch - see https://github.com/SICKAG/sick_scan_xd/commit/abd456030afbdbdc397e17450a99f935014923d2

I still find the workflow within this repo quite confusing...why do you not comment and close these PRs/Issues and feature branches then - once you pulled the changes into the master branch?

aiplemaSICKAG commented 7 months ago

Hello, thank you for your feedback. We will discuss this internally and try to come up with a good solution. Best regards, Manuel

aiplemaSICKAG commented 7 months ago

Hello, we added a develop-branch as the default branch to the repository. Please use this branch in the future for pull requests. We will try to review and merge these quickly into the develop branch. Best regards, Manuel